Add missing forceReplace param when replacing a file#637
Merged
ofahimIQSS merged 1 commit intodevelopfrom Mar 31, 2025
Merged
Conversation
g-saracca
added
Size: 3
github-project-automation
bot
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
looks good from my end, merging. |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I forgot to send
forceReplaceparam to true when replacing a file with a file that has different mime type.At some point I added it but then I removed to test something.
This PR fix what is happening now on SPA beta if you try to replace lets say a JPG file with a PNG file.
Suggestions on how to test this:
Create a dataset and add a file with .jpg extension.
Go to that file and replace it with a file with .png extension, you should be able to replace the file correctly.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
No